Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type variation in substrait: Hardcoding the numbers isn't really the proper way to do type variations. #12355

Open
alamb opened this issue Sep 6, 2024 · 0 comments

Comments

@alamb
Copy link
Contributor

alamb commented Sep 6, 2024

FWIW, hardcoding the numbers isn't really the proper way to do type variations. (Rather we should add the variation as an extension and refer to the extension's id.) However, given this is already used for default vs large, I guess adding view makes sense - and they can all be migrated at once to the proper way someday.

Originally posted by @Blizzara in #12199 (comment)

The idea here is for someone to research how this is supposed to work and then change the datafusion substrait implementation to do it

@alamb alamb changed the title Type variation in substrait: HJardcoding the numbers isn't really the proper way to do type variations. Type variation in substrait: Hardcoding the numbers isn't really the proper way to do type variations. Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant