Support convert LogicalPlan JOIN with Using constraint to SQL String

[goldmedal]

Is your feature request related to a problem or challenge?

We only support to convert JOIN with ON constraint to SQL String now. The SQL as below can't be converted now.

SELECT * FROM orders JOIN customer USING (custkey)

It will panic with the message:

NotImplemented("Unsupported join constraint: Using")

Describe the solution you'd like

The unparse rule for JOIN in datafusion/sql/src/unparser/plan.rs should be implemented.

datafusion/datafusion/sql/src/unparser/plan.rs

Lines 277 to 285 in 8bedecc

	LogicalPlan::Join(join) => {
	match join.join_constraint {
	JoinConstraint::On => {}
	JoinConstraint::Using => {
	return not_impl_err!(
	"Unsupported join constraint: {:?}",
	join.join_constraint
	)
	}

Describe alternatives you've considered

No response

Additional context

No response

[goldmedal]

By the way, I saw there're other unimplemented plans in plan.rs:

• Distinct
• Window
• Extension (I guess we need to provide some method for UserDefinedLogicalNodeCore)

Is there any plan to support them?
gentle ping @alamb

[alamb]

Is there any plan to support them?

I think we should make plans to support them!

I started collecting issues on #8661

I also filed
#10663
#10664

to track distint and window

Looking at

datafusion/datafusion/sql/src/unparser/plan.rs

Lines 83 to 91 in 8bedecc

	LogicalPlan::Explain(_)
	| LogicalPlan::Analyze(_)
	| LogicalPlan::Extension(_)
	| LogicalPlan::Prepare(_)
	| LogicalPlan::Ddl(_)
	| LogicalPlan::Copy(_)
	| LogicalPlan::DescribeTable(_)
	| LogicalPlan::RecursiveQuery(_)
	| LogicalPlan::Unnest(_) => not_impl_err!("Unsupported plan: {plan:?}"),

it actually looks like there are seveal other types of plans not yet supported (like EXPLAIN, INSERT, etc...) Maybe we should file tickets for them as well