Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying LogicalPlan and Exprs in TypeCoercion #10210

Closed
alamb opened this issue Apr 24, 2024 · 0 comments · Fixed by #10356
Closed

Stop copying LogicalPlan and Exprs in TypeCoercion #10210

alamb opened this issue Apr 24, 2024 · 0 comments · Fixed by #10356
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Apr 24, 2024

Is your feature request related to a problem or challenge?

As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see #9637)

Recent profiling (#9637 (comment)) shows that a non trivial amount of plan time happens in TypeCoercion

Describe the solution you'd like

I would like to reduce the amount of copying in this pass that it no longer appears in profiling traces

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Apr 24, 2024
@alamb alamb changed the title Stop coyping Stop copying LogicalPlan and Exprs in TypeCoercion Apr 24, 2024
@alamb alamb self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant