From a5bfedd0d599629de8ca8eba3d3aaea465c2b05b Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 5 Sep 2024 16:27:22 -0400 Subject: [PATCH] Update tests so they pass after arrow upgrade --- .../tests/cases/roundtrip_logical_plan.rs | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs b/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs index 3f4d9df0de14..98daac65e1cf 100644 --- a/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs +++ b/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs @@ -716,7 +716,7 @@ async fn all_type_literal() -> Result<()> { date32_col = arrow_cast('2020-01-01', 'Date32') AND binary_col = arrow_cast('binary', 'Binary') AND large_binary_col = arrow_cast('large_binary', 'LargeBinary') AND - view_binary_col = arrow_cast(arrow_cast('binary_view', 'Binary'), 'BinaryView') AND + view_binary_col = arrow_cast('binary_view', 'BinaryView') AND utf8_col = arrow_cast('utf8', 'Utf8') AND large_utf8_col = arrow_cast('large_utf8', 'LargeUtf8') AND view_utf8_col = arrow_cast('utf8_view', 'Utf8View');", @@ -724,21 +724,6 @@ async fn all_type_literal() -> Result<()> { .await } -/// Arrow-cast does not currently handle direct casting from utf8 to binaryView. -#[tokio::test] -async fn binaryview_type_literal_needs_casting_fix() -> Result<()> { - let err = roundtrip_all_types( - "select * from data where - view_binary_col = arrow_cast('binary_view', 'BinaryView');", - ) - .await; - - assert!( - matches!(err, Err(e) if e.to_string().contains("Unsupported CAST from Utf8 to BinaryView")) - ); - Ok(()) -} - #[tokio::test] async fn roundtrip_literal_list() -> Result<()> { roundtrip("SELECT [[1,2,3], [], NULL, [NULL]] FROM data").await