Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window.open typings file requires an update #811

Closed
3 tasks done
wrightsonm opened this issue Nov 2, 2020 · 1 comment · Fixed by #817
Closed
3 tasks done

Window.open typings file requires an update #811

wrightsonm opened this issue Nov 2, 2020 · 1 comment · Fixed by #817

Comments

@wrightsonm
Copy link
Contributor

wrightsonm commented Nov 2, 2020 •
edited
Loading

Bug Report

Problem

What is expected to happen?

Since #600 window.open is no longer overridden by InAppBrowser.
I think the typings file for Window.Open is no longer correct and window.open should be removed from the file below:

https://github.com/apache/cordova-plugin-inappbrowser/blob/master/types/index.d.ts

What does actually happen?

N/A

Information

N/A

Command or Code

N/A

Environment, Platform, Device

All platforms

Version information

Cordova 10
Android 9.0.0
IOS 6.1.1
[email protected]

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@wrightsonm wrightsonm changed the title Window.open Window.open typings file requires an update Nov 2, 2020
@timbru31
Copy link
Member

timbru31 commented Nov 2, 2020

Indeed, the open method needs to be moved to the InAppBrowser interface. PR's welcome.

@wrightsonm wrightsonm mentioned this issue Nov 12, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated typings wrightsonm/cordova-plugin-inappbrowser
2 participants
@timbru31 @wrightsonm