Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-323: (iOS) Fix crashes when using WKWebView implementation on iOS 9. #337

Merged
merged 1 commit into from
Nov 20, 2018
Merged

GH-323: (iOS) Fix crashes when using WKWebView implementation on iOS 9. #337

merged 1 commit into from
Nov 20, 2018

Conversation

dpa99c
Copy link
Contributor

@dpa99c dpa99c commented Oct 30, 2018

Platforms affected

iOS

What does this PR do?

Fixes #323. Fixes #324.

What testing has been done on this change?

Tested in container test app on iOS 9,10&12

Checklist

  • [ x] Reported an issue in the JIRA database (N/A)
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change. (N/A)

@dpa99c dpa99c force-pushed the GH-323_iOS9_crashes branch from 21fa500 to deb017d Compare October 31, 2018 09:13
@dpa99c
Copy link
Contributor Author

dpa99c commented Nov 20, 2018

@janpio Let's get this merged too - it fixes crashes on iOS 9 and (as can be seen), changes are minimal

@janpio janpio merged commit 3b82c16 into apache:master Nov 20, 2018
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug platform: ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpa99c @janpio