CB-14061: (android) comply with RFC 3986 for custom URL scheme handling #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
timbru31
force-pushed
the
fix/CB-14061-handle-more-url-schemes
branch
from
ccaa628 to
f57ede9
Compare
timbru31
changed the title
|
this PR is necessary for ionic using with auth0. Example code Auth0 use |
|
Travis failure (https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/374068004) seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
This fixes a small regression of #263 to allow more custom URL schemes for android (see comment #263 (comment))
What testing has been done on this change?
Manual testing with a custom URL scheme:
staging+d2dChecklist