CB-12941: update typings #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Jenkins failure (https://travis-ci.org/apache/cordova-plugin-inappbrowser/jobs/369798189) seems unrelated. |
timbru31
force-pushed
the
feature/update-typings
branch
from
1149ee8 to
3fc216a
Compare
|
I've rebased the PR - hopefully TravisCI will complete successfully 👍 |
|
Nope, seems our tests here are just borked. Someone will have to fix those in |
janpio
reviewed
Sep 18, 2018
nobody will keep those updated...
janpio
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
n/a - development with TypeScript
What does this PR do?
Updates the typings to match the latest published version on DefinitelyTyped.
See DefinitelyTyped/DefinitelyTyped#17192 and https://stackoverflow.com/q/42095516/1902598
What testing has been done on this change?
Project compiles again ;)
Checklist
fixes #300