Problems with 5.1.1 and cordova-plugin-antitampering 0.4.2 - too many files in the release?

[massic80]

Bug Report

Problem

I got an app that works perfectly with [email protected] and https://github.com/duddu/cordova-plugin-antitampering 0.4.2. I attempted to update cordova-ios to 5.1.1

What is expected to happen?

Everything works as expected (and as it did).

What does actually happen?

Antitampering blocks the app saying that
Anti-Tampering check failed! PathNotFoundException: No readable path retrieved for file cordova-js-src/.eslintrc.yml

Information

Looks like this file is present in 5.1.1 release, but not in 5.0.1; is that a release mistake (hence the file shouldn't be included, and the problem is on cordova-ios), or should the file be added (hence the problem is on cordova-plugin-antitampering)?

Command or Code

Just build and run the app: it crashes due to expected behavior of antitampering plugin.

Environment, Platform, Device

iOS

Version information

Cordova 9
cordova-ios 5.1.1
cordova-plugin-antitampering 0.4.2

Checklist

• I searched for existing GitHub issues
• I updated all Cordova tooling to most recent version
• I included all the necessary information above

[breautek]

The eslint config has no purpose to the end user. It's a file for the package development only. Packages were cleaned up to remove files that has no purpose for users.

So that eslint file may not be the only file that was removed/npm ignored.

[massic80]

Wow, what a quick response! :)
I'm not sure I got what you mean: I figured out that it was for development only, but I had a doubt about possible evolutions of npm or node.
So, may we remove it from the release?

[timbru31]

Actually I was to eager to ping random people. cordova-ios has not yet an .npmignore file. We are tracking it globally here: apache/cordova#113

---

@breautek as I read this issue, the file was added and was not present before

[massic80]

Thanks @timbru31 : I confirm the the file was added and was not present before

[breautek]

Ah my bad, I think the error tripped me. Reading through the error again, it's clear I originally misunderstood.

This was probably due to eslint changes that @erisu has been adding to each repo. Development config files such as the .eslint.yml file in my opinion, should not be included in the npm package since they have no purpose for the end user. The only files that should be packaged in the npm package are files that is necessary for the end user. This issue should be solved by apache/cordova#113

[martin-richter-uk]

I have the same problem, how can I fix it?

[massic80]

@martinrichterlondon While it's being solved, just set
"cordova-ios": "~5.0",
in package.json in order to force a version less than 5.1 and npm install again

[martin-richter-uk]

@massic80 - Thank you for your quick response.

I cannot due to UIWebView API Deprecation (https://ionicframework.com/blog/understanding-itms-90809-uiwebview-api-deprecation/).

[dpogue]

I've marked this issue as stale because it's been several years with no further comments. If this is still an issue in the latest cordova-ios version and an up-to-date iOS version, please let us know. Otherwise, this issue will be closed.

[dpogue]

Closing as stale.