Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#24789] Remainder of changes from #27550. #27822

Merged
merged 21 commits into from
Aug 7, 2023
Merged

[#24789] Remainder of changes from #27550. #27822

merged 21 commits into from
Aug 7, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 2, 2023

Remainder of changes from #27550 that have not yet been parceled into smaller CLs for enabling prism as default runner.

See #24789

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot removed the examples label Aug 3, 2023
@lostluck lostluck marked this pull request as ready for review August 4, 2023 21:20
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #27822 (2ea91e5) into master (ead1cef) will decrease coverage by 0.01%.
Report is 35 commits behind head on master.
The diff coverage is 37.93%.

@@            Coverage Diff             @@
##           master   #27822      +/-   ##
==========================================
- Coverage   70.87%   70.87%   -0.01%     
==========================================
  Files         861      861              
  Lines      104995   105006      +11     
==========================================
+ Hits        74419    74426       +7     
- Misses      29017    29022       +5     
+ Partials     1559     1558       -1
Flag Coverage Δ
go 53.70% <37.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/core/runtime/harness/harness.go 11.08% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/harness/statemgr.go 37.60% <0.00%> (-0.16%) ⬇️
sdks/go/pkg/beam/core/runtime/symbols.go 10.00% <0.00%> (ø)
...am/runners/prism/internal/engine/elementmanager.go 82.05% <ø> (-0.05%) ⬇️
...go/pkg/beam/runners/prism/internal/handlerunner.go 86.30% <ø> (ø)
...o/pkg/beam/runners/prism/internal/worker/bundle.go 51.64% <ø> (ø)
...dks/go/pkg/beam/runners/universal/runnerlib/job.go 0.00% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/harness/datamgr.go 56.71% <33.33%> (-0.17%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/stage.go 85.67% <50.00%> (ø)
sdks/go/pkg/beam/create.go 65.15% <100.00%> (+1.65%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.
R: @bvolpato for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

riteshghorse
riteshghorse approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

sdks/go/pkg/beam/runners/vet/vet.go Outdated Show resolved Hide resolved
@lostluck
Copy link
Contributor Author

lostluck commented Aug 7, 2023

I think the failure is a race condition between the logging output and the pipeline shutting down. Good to be aware of at least, for another prism adjustment.

@lostluck lostluck merged commit 3b112e8 into apache:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riteshghorse riteshghorse riteshghorse approved these changes

Assignees
No one assigned
Labels
gcp go io Next Action: Reviewers runners website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lostluck @riteshghorse