Fix XVR_Direct time out #25247
Fix XVR_Direct time out #25247
Conversation
|
run seed job |
Abacn
force-pushed
the
xvrdirectruntime
branch
from
2b8a9a8 to
8949340
Compare
* Bump XVR_Direct timeout to 2h * Only run GoUsingJava test suite once
Abacn
force-pushed
the
xvrdirectruntime
branch
from
8949340 to
59654c7
Compare
|
Run XVR_Direct PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #25247 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 743 743
Lines 99037 99037
=======================================
+ Hits 72273 72275 +2
+ Misses 25398 25396 -2
Partials 1366 1366
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| cleanupTask.configure { mustRunAfter goTask } | ||
| config.cleanupJobServer.configure { mustRunAfter goTask } |
There was a problem hiding this comment.
Do we need to special case these as well so that they run even if we're not depending on the goTask?
There was a problem hiding this comment.
yes, besides being a dependency to validatesCrossLanguageRunner, validatesCrossLanguageRunnerGoUsingJava task can be triggered alone, where we are doing this for Dataflow XVR postcommits. Then clean up tassks should also be configured to run after it.
There was a problem hiding this comment.
Sorry, answered wrong the yes/no question. I mean run after requirements are always configured not relevant to the dependency of validatesCrossLanguageRunnerGoUsingJava -> validatesCrossLanguageRunner, so I consider the answer is no
|
Run Java PreCommit |
|
Run CommunityMetrics PreCommit |
|
Run Java_Kafka_IO_Direct PreCommit |
|
Run Java_Pulsar_IO_Direct PreCommit |
|
different test failures in two run Java_PreCommit Kafka_IO_Direct: otherwise merging for now |
follow up of #25243
the test had chance of timeout for a while. This change reduced duplicate task for XVR postcommit tests and bump the timeout for XVR_Direct.
Bump XVR_Direct timeout to 2h
Only run GoUsingJava test suite once
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.