-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead #32821
base: master
Are you sure you want to change the base?
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas |
LGTM, however I saw one of the fixes was reverted: #32701 (comment), feel free to merge if get confirm that the original issue indeed fixed and stablelized |
Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj |
What is the current status here? It looks like we have a LGTM but checks are failing |
The PR that fixed the original issue was reverted, so we'll wait until a future fix gets in. This change isn't urgent in any way, so will turn it into a draft until then |
Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj |
Waiting on author |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
We were using a workaround because of an issue in ByteBuddy (#32701). This has been fixed so we can now use ByteBuffer normally
Note that this is an update compatible change because
byte[]
andByteBuffer
types will both map to the sameBYTES
Schema type