Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead #32821

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Oct 16, 2024

We were using a workaround because of an issue in ByteBuddy (#32701). This has been fixed so we can now use ByteBuffer normally

Note that this is an update compatible change because byte[] and ByteBuffer types will both map to the same BYTES Schema type

@github-actions github-actions bot added the build label Oct 16, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas

@Abacn
Copy link
Contributor

Abacn commented Oct 25, 2024

LGTM, however I saw one of the fixes was reverted: #32701 (comment), feel free to merge if get confirm that the original issue indeed fixed and stablelized

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damccorm for label build.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj

@damccorm
Copy link
Contributor

What is the current status here? It looks like we have a LGTM but checks are failing

@ahmedabu98
Copy link
Contributor Author

The PR that fixed the original issue was reverted, so we'll wait until a future fix gets in. This change isn't urgent in any way, so will turn it into a draft until then

@ahmedabu98 ahmedabu98 marked this pull request as draft November 19, 2024 20:32
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj

@ahmedabu98
Copy link
Contributor Author

Waiting on author

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants