Upgrade grpcio to 1.65.5 #32806
Upgrade grpcio to 1.65.5 #32806
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Let me know if we are fine with this PR. The failed YAML test is not related to this PR. |
| @@ -359,7 +359,7 @@ def get_portability_package_data(): | |||
| 'fastavro>=0.23.6,<2', | |||
| 'fasteners>=0.3,<1.0', | |||
| # TODO(https://github.com/grpc/grpc/issues/37710): Unpin grpc | |||
| 'grpcio>=1.33.1,<2,!=1.48.0,!=1.59.*,!=1.60.*,!=1.61.*,!=1.62.0,!=1.62.1,<1.66.0', # pylint: disable=line-too-long | |||
| 'grpcio>=1.65.5,<1.66.0', | |||
There was a problem hiding this comment.
Per https://github.com/apache/beam/pull/32773/files#r1800175195 I think we can at least bump the lower bound down to 1.65.2, right?
From #32784 it looks like we do indeed need this change, but I'd like @tvalentyn to weigh in as well. I don't really love making the boundaries so tight, but it seems like we might not have a choice
There was a problem hiding this comment.
Based on #32773 (comment), I think the lower bound should be 1.65.5 although it is tight.
There was a problem hiding this comment.
I don't really love making the boundaries so tight
+1. Discussed another suggestion offline on how we could revert the grpcio-tools version bump.
|
Looks like updating our notebook container test is working. Close this PR. |
Address #32773 and #32784
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.