Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: vendored jars leak proto #32758

Closed
1 of 17 tasks
Abacn opened this issue Oct 11, 2024 · 2 comments · Fixed by #32958
Closed
1 of 17 tasks

[Bug]: vendored jars leak proto #32758

Abacn opened this issue Oct 11, 2024 · 2 comments · Fixed by #32958
Assignees

Comments

@Abacn
Copy link
Contributor

Abacn commented Oct 11, 2024

What happened?

Beam vendors a few dependencies (grpc, guava). These vendored dependency jars have package namespace shaded (* -> org/apache/beam/vendor/*) so it won't leak classes. However this repackage does not contain protos, as a result, it still leaks proto sources

For example, in org.apache.beam » beam-vendor-grpc-1_60_1 » 0.2:

beam-vendor-grpc-1_60_1-0.2
|-grpc
|  |-google
|  |  |-api
|  |  |  |-field_behavior.proto
...

Protobuf error

@zhumin8 created a reproducer with Protobuf Gradle plugin where it gets protoc: stdout: . stderr: sample.proto:6:52: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior":

https://github.com/zhumin8/cloud-opensource-java/tree/test/boms/test-gradle

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Oct 11, 2024

marked as 2.62.0 release blocker (cut on Dec 18, 2024)

@suztomo
Copy link
Contributor

suztomo commented Oct 11, 2024

Added "Protobuf error" section in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants