-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin protobuf version for TF dependency tests #32719
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
hmm, this is working locally but the protobuf version is getting clobbered when the action runs. weird. |
for the record this is still not working, the protobuf version keeps being upgraded. current idea is to just disable these tests so we get signal from the rest of the suite while I figure out how to fix them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32719 +/- ##
============================================
+ Coverage 58.84% 58.92% +0.07%
Complexity 3091 3091
============================================
Files 1130 1130
Lines 174103 174399 +296
Branches 3312 3312
============================================
+ Hits 102451 102764 +313
+ Misses 68326 68309 -17
Partials 3326 3326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Okay, got a clean run on https://github.com/apache/beam/actions/runs/11298052670/job/31426200604 (the numpy failures have been fixed on master) |
PTAL at lint errors |
I don't understand how there's a linting failure when the only file changed isn't python and doesn't get linted... |
Everything green, merging |
* Pin protobuf version for TF dependency tests * pin specfic protobuf version * increment tested TF version * pin at higher version of protobuf * fix incorrect configuration * try bumping tf version * further specify dependency versions * try adding other ml testing deps for compat * fix transformers tests * tweak deps for transformers * whitespace
The Tensorflow dependency test running against TensorFlow 2.12 was failing as the test environment was separately installing protobuf 5.x. This ensures that an appropriate protobuf version is installed before installing beam deps.
Fresh run of the workflow against this branch is running at https://github.com/apache/beam/actions/runs/11258372012 - there are some pandas/numpy failures that are unrelated.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.