Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf version for TF dependency tests #32719

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Pin protobuf version for TF dependency tests #32719

merged 11 commits into from
Oct 14, 2024

Conversation

jrmccluskey
Copy link
Contributor

The Tensorflow dependency test running against TensorFlow 2.12 was failing as the test environment was separately installing protobuf 5.x. This ensures that an appropriate protobuf version is installed before installing beam deps.

Fresh run of the workflow against this branch is running at https://github.com/apache/beam/actions/runs/11258372012 - there are some pandas/numpy failures that are unrelated.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor Author

hmm, this is working locally but the protobuf version is getting clobbered when the action runs. weird.

@jrmccluskey
Copy link
Contributor Author

for the record this is still not working, the protobuf version keeps being upgraded. current idea is to just disable these tests so we get signal from the rest of the suite while I figure out how to fix them

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.92%. Comparing base (02e0b3a) to head (99b6906).
Report is 40 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32719      +/-   ##
============================================
+ Coverage     58.84%   58.92%   +0.07%     
  Complexity     3091     3091              
============================================
  Files          1130     1130              
  Lines        174103   174399     +296     
  Branches       3312     3312              
============================================
+ Hits         102451   102764     +313     
+ Misses        68326    68309      -17     
  Partials       3326     3326              
Flag Coverage Δ
python 81.51% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccluskey
Copy link
Contributor Author

Okay, got a clean run on https://github.com/apache/beam/actions/runs/11298052670/job/31426200604 (the numpy failures have been fixed on master)

@tvalentyn
Copy link
Contributor

PTAL at lint errors

@jrmccluskey
Copy link
Contributor Author

I don't understand how there's a linting failure when the only file changed isn't python and doesn't get linted...

@jrmccluskey
Copy link
Contributor Author

Everything green, merging

@jrmccluskey jrmccluskey merged commit b94f8a7 into master Oct 14, 2024
94 of 95 checks passed
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Pin protobuf version for TF dependency tests

* pin specfic protobuf version

* increment tested TF version

* pin at higher version of protobuf

* fix incorrect configuration

* try bumping tf version

* further specify dependency versions

* try adding other ml testing deps for compat

* fix transformers tests

* tweak deps for transformers

* whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants