Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerA…

[manitgupta]

This reverts commit efee92b.

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @damondouglas for label io.
R: @nielm for label spanner.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[Abacn]

did efee92b introduce a regression? If so is this fix needed a cherry-pick into upcoming 2.60.0 release?

[nielm]

did efee92b introduce a regression? If so is this fix needed a cherry-pick into upcoming 2.60.0 release?

In some situations, yes, so yes please. can you cherry-pick (do you want a regression bug?)

Specific cause:

Spanner has a max number of 400 sessions in a session pool, where a session is used for a read or a write operation.

When using streaming pipelines on Dataflow with a high degree of parallelisation, where each work item can be reading from and writing to spanner, Dataflow will have up to 300 threads per worker, which potentially means 300 simultaneous read sessions, and 300 simultaneous downstream writes.

In some scenarios, this can lead to session pool exhaustion, followed by a worker failing due to this flag.

[Abacn]

thanks. could you please open a cherry-pick PR, that is checkout release-2.60.0 branch, run git cherry-pick bcd785f, and open a PR with release-2.60.0 as the base branch, similar to #32663

[nielm]

thanks. could you please open a cherry-pick PR, that is checkout release-2.60.0 branch, run git cherry-pick bcd785f, and open a PR with release-2.60.0 as the base branch, similar to #32663

Done: #32702