Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sharing models across steps #31665

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jun 21, 2024

Sometimes it is useful to have 2 steps that use the same model (e.g. an LLM doing 2 different tasks at different parts of the pipeline). This enables that behavior via a flag passed to the RunInference instance


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (aabf7d0) to head (db22dc4).
Report is 16 commits behind head on master.

Current head db22dc4 differs from pull request most recent head 83e7b79

Please upload reports for the commit 83e7b79 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #31665      +/-   ##
============================================
+ Coverage     71.40%   71.41%   +0.01%     
  Complexity     1474     1474              
============================================
  Files           900      900              
  Lines        114179   114219      +40     
  Branches       1076     1076              
============================================
+ Hits          81526    81573      +47     
+ Misses        30624    30617       -7     
  Partials       2029     2029              
Flag Coverage Δ
python 81.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damccorm damccorm marked this pull request as ready for review June 21, 2024 14:00
@damccorm
Copy link
Contributor Author

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Super simple to add, very cool feature

Copy link
Contributor

@rezarokni rezarokni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future PR, would be interesting to explore if there is a way to determine if a user has accidentally set the same tag for different models.

@damccorm damccorm merged commit 14fd366 into master Jun 21, 2024
87 checks passed
@damccorm damccorm deleted the users/damccorm/shareModelAcrossSteps branch June 21, 2024 14:51
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Add support for sharing models across steps

* Tests + CHANGES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants