Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Teardown method is never called #31381

Open
1 of 16 tasks
boolangery opened this issue May 23, 2024 · 2 comments
Open
1 of 16 tasks

[Bug]: Teardown method is never called #31381

boolangery opened this issue May 23, 2024 · 2 comments

Comments

@boolangery
Copy link

What happened?

Teardown is never called when running locally with prism or on Dataflow.

Tested signature: Teardown(ctx context.Context) error

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor

Abacn commented Jul 23, 2024

Same happens on Python SDK run on Dataflow. Python direct runner has teardown called.

edit:

did some more tests for Dataflow Python

error throw in startBundle / process /finishbundle - teardown called

error throw in setup - teardown not called

This is different from Java Dataflow runner v2, where tearDown isn't called after throw in startBundle, finishBundle, process

@Abacn
Copy link
Contributor

Abacn commented Jul 23, 2024

The same for Dataflow Java (runner v1/v2): #18592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants