Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive tests for Beam Notebooks release #28880

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix interactive tests for Beam Notebooks release #28880

merged 1 commit into from
Oct 6, 2023

Conversation

jonathan-lemos
Copy link
Contributor

@jonathan-lemos jonathan-lemos commented Oct 6, 2023

Specific fixes are as follows:

  • Update chromedriver to 117
  • Update golden screenshots
  • Enforce urllib3 <2.x.x

Tested this with the following:

cd sdks/python
python setup.py bdist_wheel --universal
pip install --upgrade -e '.[interactive_test,test,interactive]'
pytest -rsx -v apache_beam/runners/interactive/testing/integration/tests

This fails before the changes and succeeds after.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

update chromedriver to 117
update golden screenshots
enforce urllib3 <2.x.x
@github-actions github-actions bot added the python label Oct 6, 2023
@jonathan-lemos
Copy link
Contributor Author

R: @liferoad

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn tvalentyn merged commit 7531501 into apache:master Oct 6, 2023
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants