Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable typevar-name-mismatch check #28849

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

jrmccluskey
Copy link
Contributor

Enables the typevar-name-mismatch pylint check and skips the check on the one instance the rule is violated within the Python sdk (which was already skipped for mypy checks.)

Fixes #28241


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #28849 (03e840b) into master (2e05211) will decrease coverage by 0.02%.
Report is 28 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28849      +/-   ##
==========================================
- Coverage   72.24%   72.23%   -0.02%     
==========================================
  Files         684      684              
  Lines      101230   101235       +5     
==========================================
- Hits        73133    73124       -9     
- Misses      26521    26535      +14     
  Partials     1576     1576              
Flag Coverage Δ
python 82.78% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor Author

R: @riteshghorse

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrmccluskey jrmccluskey merged commit b876299 into apache:master Oct 6, 2023
77 checks passed
@jrmccluskey jrmccluskey deleted the typevarMismatch branch October 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Enable the typevar-name-mismatch pylint check
2 participants