Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rewrite project version in BeamModulePlugin #28843

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

kennknowles
Copy link
Member

The intended project version source of truth is gradle.properties. It is set statically to either -SNAPSHOT when on a non-terminal commit or non-SNAPSHOT on terminal RC commits.

This change eliminates one place where that source of truth is both duplicated and violated.

Discovered when this behavior broke 2.51.0 RC builds by adding -SNAPSHOT to them.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles kennknowles requested a review from damccorm October 5, 2023 11:15
@github-actions github-actions bot added the build label Oct 5, 2023
@kennknowles
Copy link
Member Author

R: @damccorm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #28843 (27a9f92) into master (161cd6b) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28843      +/-   ##
==========================================
- Coverage   72.22%   72.21%   -0.01%     
==========================================
  Files         684      684              
  Lines      101230   101230              
==========================================
- Hits        73110    73107       -3     
- Misses      26545    26548       +3     
  Partials     1575     1575              
Flag Coverage Δ
python 82.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennknowles
Copy link
Member Author

Failed to store cache entry.

@kennknowles
Copy link
Member Author

Run Java_Kinesis_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

R: @lostluck

@kennknowles
Copy link
Member Author

Running some internal tests too, to check that it plays nice with Google's build system wrapper of Beam's build (and I'll just fix internal breakages, since IMO this is obviously correct for Beam)

@kennknowles
Copy link
Member Author

Yup, passed global presubmit

@kennknowles kennknowles merged commit 5d49733 into apache:master Oct 5, 2023
23 checks passed
@kennknowles kennknowles deleted the no-duplicate-SNAPSHOT branch October 5, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants