-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rewrite project version in BeamModulePlugin #28843
Conversation
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28843 +/- ##
==========================================
- Coverage 72.22% 72.21% -0.01%
==========================================
Files 684 684
Lines 101230 101230
==========================================
- Hits 73110 73107 -3
- Misses 26545 26548 +3
Partials 1575 1575
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Failed to store cache entry. |
Run Java_Kinesis_IO_Direct PreCommit |
R: @lostluck |
Running some internal tests too, to check that it plays nice with Google's build system wrapper of Beam's build (and I'll just fix internal breakages, since IMO this is obviously correct for Beam) |
Yup, passed global presubmit |
The intended project version source of truth is gradle.properties. It is set statically to either
-SNAPSHOT
when on a non-terminal commit or non-SNAPSHOT
on terminal RC commits.This change eliminates one place where that source of truth is both duplicated and violated.
Discovered when this behavior broke 2.51.0 RC builds by adding
-SNAPSHOT
to them.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.