Fix various issues in SplunkIO #28825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @bvolpato |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
pranavbhandari24
force-pushed
the
forked-io
branch
from
2b65edb to
fc4ec49
Compare
pranavbhandari24
changed the title
fields metadata
pranavbhandari24
force-pushed
the
forked-io
branch
2 times, most recently
from
1ff6f2b to
818fc13
Compare
bvolpato
reviewed
Oct 12, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderProviders.java
Outdated
Show resolved
Hide resolved
bvolpato
reviewed
Oct 12, 2023
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEventWriter.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
pranavbhandari24
force-pushed
the
forked-io
branch
from
818fc13 to
28ebee9
Compare
|
there are spotless and chexkstyle violations, see https://github.com/apache/beam/actions/runs/6535063663/job/17743650936?pr=28825 |
pranavbhandari24
force-pushed
the
forked-io
branch
from
28ebee9 to
91a9621
Compare
pranavbhandari24
force-pushed
the
forked-io
branch
from
91a9621 to
2df21ea
Compare
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Oct 21, 2023
* Fix GZIP compression in HttpEventPublisher. * Add checks to make sure the provided URL is valid. * Fix issue with DefaultCoder in AutoValue generated classes. * Add support for Splunk `fields` metadata. Also fix Coder issues for SplunkEvent. * Address comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following improvements/bug fixes,
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.