-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigtableIO: Force minimum value of desiredBundleSizeBytes
to be 1
#28798
BigtableIO: Force minimum value of desiredBundleSizeBytes
to be 1
#28798
Conversation
4cf0310
to
9456610
Compare
desiredBundleSizeBytes
to be 1
41b32c7
to
87960f7
Compare
Fixes apache#28793 in the way suggested in apache#28793 (comment): - `BoundedReadEvaluatorFactory#getInitialInputs` may still calculate a `bytesPerBundle` of `0`; but - `BigtableSource#split` will interpret it as `1` in order to not violate the `checkArgument()` in https://github.com/apache/beam/blob/71c8459633ec86e576eca080a26be9f42474ecb2/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java#L1623-L1626
87960f7
to
7ed57ef
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix LGTM, just +1 on moving the CHANGES.md delta to 2.52.0 since 2.51.0 is almost out / at release candidate fix.
b854f02
to
afe1dc9
Compare
The "PreCommit Whitespace" failure seems to me to be unrelated to the changes in this PR:
Edit: It could also be caused by the modifications to CHANGES.md, in which case it's not a great error message. |
7b840f2
to
3096265
Compare
Running $ python -m pip install --user whitespacelint==1.1.0
Requirement already satisfied: whitespacelint==1.1.0 in /home/joar/.local/lib/python3.8/site-packages (1.1.0)
$ whitespacelint CHANGES.md
# exits with 0
$ git rev-parse HEAD
3096265e05ff59ae192cc7f4a571e9247937211b |
whitespace issue was an issue on master and now fixed #28845 |
Fixes #28793 in the way suggested in #28793 (comment):
BoundedReadEvaluatorFactory#getInitialInputs
may still calculate abytesPerBundle
of0
(e.g. whentargetParallelism > estimatedBytes
); butBigtableSource#split
will interpret it as1
in order to not violate thecheckArgument()
inbeam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Lines 1623 to 1626 in 71c8459
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.