Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Support custom BQ schema for perf alert tool #28668

Closed
15 tasks
AnandInguva opened this issue Sep 26, 2023 · 0 comments · Fixed by #28671
Closed
15 tasks

[Task]: Support custom BQ schema for perf alert tool #28668

AnandInguva opened this issue Sep 26, 2023 · 0 comments · Fixed by #28671
Assignees
@AnandInguva
Labels
P2 perf-alert Automatically filed performance-related alerts. task
Milestone
2.52.0 Release

Comments

@AnandInguva
Copy link
Contributor

What needs to happen?

Right now, perf alert tool uses the default schema

beam/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py

Line 70 in a7e12db

SCHEMA = [{
to read the metric values and timestamps.

If someone wants to use a different BQ schema, they won't be able to do so. Support BQ schema parameterization for the perf alert tool.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@AnandInguva AnandInguva added task perf-alert Automatically filed performance-related alerts. labels Sep 26, 2023
@AnandInguva AnandInguva self-assigned this Sep 26, 2023
@github-actions github-actions bot added the P2 label Sep 26, 2023
@AnandInguva AnandInguva mentioned this issue Sep 26, 2023
Merged
3 tasks
@github-actions github-actions bot added this to the 2.52.0 Release milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnandInguva AnandInguva

Labels
P2 perf-alert Automatically filed performance-related alerts. task
Projects
None yet
Milestone
2.52.0 Release
Development

Successfully merging a pull request may close this issue.

Support for custom MetricsFetcher in Perf tooling. AnandInguva/beam
1 participant
@AnandInguva