Rearrange Java Example tests on Dataflow #28565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passed on e864092 the last commit just fixes README.md, ready for review |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Jenkins dataflow java11 test failing "ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS" . Note that the seed job not run and test still run full precommit (V1appliance+V1streaming engine+V2), not related |
damondouglas
approved these changes
Sep 21, 2023
kennknowles
pushed a commit
to kennknowles/beam
that referenced
this pull request
Sep 22, 2023
* Rearrange Java Example tests on Dataflow * Fix readme
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28561
Issues mentioned in above are fixed
Leave the issue open because the last point is not addressed in this PR (Example tests are defined in two different files), which requires larger scope of refactor
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.