-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining tests for pandas 2 compatibility #28524
Conversation
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28524 +/- ##
==========================================
+ Coverage 72.23% 72.25% +0.01%
==========================================
Files 684 684
Lines 100992 100931 -61
==========================================
- Hits 72951 72926 -25
+ Misses 26466 26430 -36
Partials 1575 1575
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python_Coverage PreCommit |
PTAL. Skipped the xs test as discussed, and pytest passes everything for me lets see if it fails again here. |
which of the 1-4 chages affected pandas 1.4 ? |
None, I had just removed a doc test thinking it was covered by something
else but it wasn't.
…On Wed, Sep 20, 2023, 6:17 PM tvalentyn ***@***.***> wrote:
which of the 1-4 chages affected pandas 1.4 ?
—
Reply to this email directly, view it on GitHub
<#28524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG4SH4Z4TH4JKCO7KQRPMTX3NTNZANCNFSM6AAAAAA46BSVAU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Fix the remaining tests without open questions.
Umbrella Issue: #27221