Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining tests for pandas 2 compatibility #28524

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 19, 2023

Fix the remaining tests without open questions.

  1. Fix doctests. The new skips are all just new examples in Pandas 2 docs of things we were already skipping with Pandas 1.x doctests.
  2. Expose set_eng_float_format, not new with Pandas 2 but has doc examples now where it didn't before so they caught that this should be exposed.
  3. Skip remaining tests that have level in them that I missed earlier
  4. Explicitly set numeric_only=True in the interactive runner test as I have in other tests (this test is not testing the functionality of numeric_only so it doesn't matter).

Umbrella Issue: #27221

@caneff
Copy link
Contributor Author

caneff commented Sep 19, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #28524 (6f1b655) into master (17db78c) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28524      +/-   ##
==========================================
+ Coverage   72.23%   72.25%   +0.01%     
==========================================
  Files         684      684              
  Lines      100992   100931      -61     
==========================================
- Hits        72951    72926      -25     
+ Misses      26466    26430      -36     
  Partials     1575     1575              
Flag Coverage Δ
python 82.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pache_beam/dataframe/pandas_top_level_functions.py 90.62% <100.00%> (+0.09%) ⬆️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor

Run Python_Coverage PreCommit

@caneff
Copy link
Contributor Author

caneff commented Sep 20, 2023

PTAL. Skipped the xs test as discussed, and pytest passes everything for me lets see if it fails again here.

@tvalentyn
Copy link
Contributor

which of the 1-4 chages affected pandas 1.4 ?

@caneff
Copy link
Contributor Author

caneff commented Sep 20, 2023 via email

@tvalentyn tvalentyn merged commit fee9808 into apache:master Sep 21, 2023
77 checks passed
@caneff caneff deleted the tests branch September 21, 2023 17:26
kennknowles pushed a commit to kennknowles/beam that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants