Support kw only arguments for frame methods for Pandas 2 #28454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level was always NotImplemented anyway, and errors I conditionally disable based on the pandas version to keep functionality.
Pandas removed .append in 2.0 so this helps keep the API consistent.
Pandas 2 has made most args of most methods kw only. This still supports Pandas 1 while allowing for those.
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Python_Coverage PreCommit |
|
Run Python_Runners PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #28454 +/- ##
==========================================
- Coverage 72.34% 72.34% -0.01%
==========================================
Files 683 683
Lines 100708 100715 +7
==========================================
+ Hits 72858 72859 +1
- Misses 26273 26279 +6
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tvalentyn
reviewed
Sep 15, 2023
tvalentyn
approved these changes
Sep 15, 2023
|
Run Python PreCommit |
|
Run Python_Runners PreCommit |
|
Run Python PreCommit |
tvalentyn
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 2 turns most args of most of its methods into kwonly args.
args_to_kwargs and populate_defaults needed to be changed to look there, and there were a few locations that called pandas methods by location only that had to be updated to call by keyword.
Partially fixes #27221.