Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Upload JUnit test report for github action runs #28012

Closed
15 tasks
Abacn opened this issue Aug 15, 2023 · 2 comments
Closed
15 tasks

[Task]: Upload JUnit test report for github action runs #28012

Abacn opened this issue Aug 15, 2023 · 2 comments
Labels
awaiting triage github_actions Pull requests that update GitHub Actions code P2 task

Comments

@Abacn
Copy link
Contributor

Abacn commented Aug 15, 2023

What needs to happen?

Currently the test log only shows a brief summary for failed tests, with truncated traceback. e.g., in https://github.com/apache/beam/actions/runs/5870324548/job/15917132120

> Task :runners:google-cloud-dataflow-java:arm:examplesJavaRunnerV2IntegrationTestARM

org.apache.beam.examples.WordCountIT > testE2EWordCount FAILED
    java.lang.IllegalArgumentException at WordCountIT.java:58
        Caused by: java.lang.ClassNotFoundException at WordCountIT.java:58

org.apache.beam.examples.WindowedWordCountIT > testWindowedWordCountInStreamingStaticSharding FAILED
    java.lang.IllegalArgumentException at WindowedWordCountIT.java:118
        Caused by: java.lang.ClassNotFoundException at WindowedWordCountIT.java:118

org.apache.beam.examples.WindowedWordCountIT > testWindowedWordCountInBatchStaticSharding FAILED
    java.lang.IllegalArgumentException at WindowedWordCountIT.java:118
        Caused by: java.lang.ClassNotFoundException at WindowedWordCountIT.java:118

org.apache.beam.examples.WindowedWordCountIT > testWindowedWordCountInBatchDynamicSharding FAILED
    java.lang.IllegalArgumentException at WindowedWordCountIT.java:118
        Caused by: java.lang.ClassNotFoundException at WindowedWordCountIT.java:118

4 tests completed, 4 failed

Moreover, upload artifact step is skipped if the previous test failed.
This makes no sense because most cases only when test fails we want to look at the test results.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn Abacn added task awaiting triage github_actions Pull requests that update GitHub Actions code labels Aug 15, 2023
@github-actions github-actions bot added the P2 label Aug 15, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Aug 16, 2023

#27996 added reports/tests to actions/upload-artifact@v3 but it does not work -- "Warning: No files were found with the provided path: "/build/test-results//.xml"
"/build/reports/tests//
.*". No artifacts will be uploaded."

The test command executing locally indeed generates report in build/reports/tests/**. Need to investigate further

@Abacn
Copy link
Contributor Author

Abacn commented Sep 21, 2023

We now use EnricoMi/publish-unit-test-result-action@v2 and also Archive JUnit Test Results

@Abacn Abacn closed this as completed Sep 21, 2023
@github-actions github-actions bot added this to the 2.52.0 Release milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage github_actions Pull requests that update GitHub Actions code P2 task
Projects
None yet
Development

No branches or pull requests

1 participant