Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM test suite trigger commands to mass comment script #27982

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

celeste-zeng
Copy link
Contributor

  • Add new trigger phrases for all post commit ARM test suites.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Aug 12, 2023
@tvalentyn
Copy link
Contributor

tvalentyn commented Aug 12, 2023

i think we should add commands into a text file for consistency and simplicity; there is jenkins_jobs.txt. @damccorm should we rename that file to smth like test_trigger_commands.txt or there is some advantage to split Jenkins and GH actions trigger commands in separate files?

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #27982 (4dcc3f7) into master (6b3ce09) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27982      +/-   ##
==========================================
+ Coverage   72.33%   72.38%   +0.04%     
==========================================
  Files         680      679       -1     
  Lines      100263   100112     -151     
==========================================
- Hits        72530    72470      -60     
+ Misses      26162    26075      -87     
+ Partials     1571     1567       -4     
Flag Coverage Δ
python 82.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor

@damccorm should we rename that file to smth like test_trigger_commands.txt or there is some advantage to split Jenkins and GH actions trigger commands in separate files?

I think splitting into separate files makes sense. Jenkins triggers can be programatically determined (and we do that to update them as part of our release process) so having a distinct file for them makes management easy

@celeste-zeng
Copy link
Contributor Author

Run Go PostCommit Dataflow ARM

'''
Returns all trigger commands that will start PostCommit ARM Github Actions test suites.
'''
arm_trigger_commands = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a comment along the lines of: remove this special case once this script can handle GitHub Actions triggers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should I just create a github_actions_jobs.txt now instead and move all the trigger commands there? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think leaving it is fine for now (with the comment added). Solving trigger commands for actions is an open question that will need to be solved generally soon anyways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks! But since there are multiple versions of Java and Python, I also need to adjust the trigger command to "Run Java_Examples_Dataflow_ARM PostCommit 11" "Run Python ValidatesContainer Dataflow ARM 3.8"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should do that as well

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one more comment, otherwise LGTM

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@celeste-zeng
Copy link
Contributor Author

Run Go PreCommit

@tvalentyn tvalentyn merged commit 6d5048e into apache:master Sep 1, 2023
@celeste-zeng celeste-zeng deleted the trigger-command branch September 5, 2023 17:05
@kennknowles
Copy link
Member

#28663 (comment) :-)

@kennknowles
Copy link
Member

Here is the console output for mass_comment.py which will give the hint needed to fix this:

...
('Run PythonFormatter PreCommit', 'beam_PreCommit_PythonFormatter_Phrase')
('Run PythonLint PreCommit', 'beam_PreCommit_PythonLint_Phrase')
('Run RAT PreCommit', 'beam_PreCommit_RAT_Phrase')
('Run Spotless PreCommit', 'beam_PreCommit_Spotless_Phrase')
('Run Typescript PreCommit', 'beam_PreCommit_Typescript_Phrase')
('Run Whitespace PreCommit', 'beam_PreCommit_Whitespace_Phrase')
Run Go PostCommit Dataflow ARM
Run Java_Examples_Dataflow_ARM PostCommit 8
Run Java_Examples_Dataflow_ARM PostCommit 11
Run Java_Examples_Dataflow_ARM PostCommit 17
...

@Abacn
Copy link
Contributor

Abacn commented Sep 26, 2023

I see the issue, going to fix along with #28665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants