Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][Java SDK]: Increase PubsubWriteSchemaTransformProvider integration test coverage #24462

Open
6 tasks
damondouglas opened this issue Dec 1, 2022 · 0 comments

Comments

@damondouglas
Copy link
Contributor

damondouglas commented Dec 1, 2022

What work does this Task describe?

This task extends the work of #24443 by increasing coverage of PubsubWriteSchemaTransformProviderIT. The #24443 PR began this task by completing tests that detect errors in writing simple bytes only payload to a non-schema defined Pub/Sub topic within an integration testing context. However, prior to the PR's submission, attempts failed at validating the same for serialized Avro formatted payload Rows written to an Avro schema containing Pub/Sub topic.

What value may result from this Task's output?

While #24443 covers on a unit test level cases addressed in this task, integration testing provides harder empirical measures of code errors that additionally signal gaps in unit test level coverage. End users will be using the code from #24443 from real Google Cloud Pub/Sub and not mocked resources as achieved in that PR.

Ready and Done Measures

Ready

The following are blockers for beginning this task.

Done

The following are measures that define this task as complete.

Within an integration testing context, tests detect errors when:

  • serializing an Avro formatted Row payload and writing to a Pub/Sub topic lacking a schema definition
  • serializing a Json formatted Row payload and writing to a Pub/Sub topic lacking a schema definition
  • forwarding the proto not supported when attempting to write to a Pub/Sub topic containing PROTOCOL_BUFFER schema
  • forwarding Schema mismatch between the Row payload and the Pub/Sub topic Avro schema
  • serializing a Json formatted Row and writing to a Pub/Sub topic Avro schema

Issue Priority

Priority: 3

Issue Component

Component: io-java-gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants