Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flake]: Spark batch flakes in ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement and ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle #23709

Closed
kennknowles opened this issue Oct 18, 2022 · 5 comments

Comments

@kennknowles
Copy link
Member

What happened?

This test has been historically flaky, and flaked here:

Issue Priority

Priority: 1

Issue Component

Component: runner-spark

@kennknowles
Copy link
Member Author

Forked from #19814

@kennknowles
Copy link
Member Author

Unfortunately not so easy to reproduce. This passed:

for i in `seq 1 100` ; do (
  echo "RUN $i"
  ./gradlew :runners:spark:3:cleanTest --quiet
  ./gradlew :runners:spark:3:validatesRunnerBatch --quiet --tests ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement
) 2>/dev/null
done

Either it depends on resource constraints on Jenkins due to concurrency or it flakes less often.

@kennknowles kennknowles removed their assignment Oct 18, 2022
@kennknowles kennknowles added the P1 label Oct 18, 2022
@kennknowles
Copy link
Member Author

Leaving open but opportunistically moving to a bug I can repro. This one is in the unfortunate state where I know it is real so I can't close it but I cannot repro.

@kennknowles kennknowles changed the title [Flake]: Spark batch flakes in ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement [Flake]: Spark batch flakes in ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement and ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle Oct 18, 2022
@manuzhang
Copy link
Contributor

shall we downgrade priority for such flaky tests?

@damccorm
Copy link
Contributor

I think this is fixed. If not, it should get auto-flagged by our tooling anyways, so this should be safe to close

@github-actions github-actions bot added this to the 2.61.0 Release milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants