Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Be able to Pass additional args to automated expansion service startup [Go SDK] #22302

Open
lostluck opened this issue Jul 15, 2022 · 0 comments

Comments

@lostluck
Copy link
Contributor

lostluck commented Jul 15, 2022

What happened?

Edit: Changed from Bug to New Feature
We should be able to plumb additional flags to the automatically started up Java Expansion service, in case there are specific flags IOs need. Eg. for a recent KafkaIO issue that didn't appear to be able to worked around centrally. What follows is the original bug and proposal.

The Java KafkaIO SDF implementation is experiencing issues #21730 and the Xlang wrappers need to be updated to pass an experiment flag to the Java Expansion service.

This issue tracks doing the same to the Go KafkaIO wrapper, to pass the additional args to the automatically started up expansion service, as it was done to the python wrapper in #22286.

--experiments=use_unbounded_sdf_wrapper in particular.

https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/xlang/kafkaio/kafka.go#L90

Additional args can probably be added as a new "ExpansionServiceOption"

func UseAutomatedJavaExpansionService(gradleTarget string, opts ...ExpansionServiceOption) string {

And plumbed through to

func QueryAutomatedExpansionService(ctx context.Context, p *HandlerParams) (*jobpb.ExpansionResponse, error) {
for the started service.

Issue Priority

Priority: 2

Issue Component

Component: sdk-go

@lostluck lostluck changed the title [Bug]: Update Go KafkaIO wrapper to work around #21730 (Pass additional args to automated expansion service startup) [New Feature]: Be able to Pass additional args to automated expansion service startup [Go SDK] Jul 15, 2022
@lostluck lostluck added new feature and removed bug labels Jul 15, 2022
@github-actions github-actions bot added the P2 label Jul 15, 2022
@lostluck lostluck removed the kafka label Jul 15, 2022
@github-actions github-actions bot added the stale label Sep 14, 2022
@damccorm damccorm removed the stale label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants