Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated strings.Title #21514

Closed
damccorm opened this issue Jun 5, 2022 · 0 comments · Fixed by #25385
Closed

Replace use of deprecated strings.Title #21514

damccorm opened this issue Jun 5, 2022 · 0 comments · Fixed by #25385
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. go P3 sub-task

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 5, 2022

strings.Title is deprecated as of Go 1.18, and an alternative in to form of golang.org/x/text/cases should be used instead (present in Go since 1.0)

 

An initial exploration found that there isn't a language tag to pass in to cases.Title() that matches the current strings.Title behavior perfectly. More work will need to be done to match existing behavior. 

Imported from Jira BEAM-14249. Original Jira may contain additional context.
Reported by: jrmccluskey.
Subtask of issue #21513

@damccorm damccorm added go and removed sdk-go labels Jun 16, 2022
@github-actions github-actions bot added this to the 2.46.0 Release milestone Feb 8, 2023
@lostluck lostluck added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. go P3 sub-task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants