Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextIO.write .withWindowedWrites does not work on windows #21317

Open
damccorm opened this issue Jun 4, 2022 · 2 comments
Open

TextIO.write .withWindowedWrites does not work on windows #21317

damccorm opened this issue Jun 4, 2022 · 2 comments
Assignees
@DwaipayanSom
Labels
bug good first issue io java P3 text

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

This basic code fails on MS Windows

.apply(TextIO.write().to("anything")
.withWindowedWrites()
.withNumShards(1)

with

java.nio.file.InvalidPathException: Illegal char <:> at index 16: anything2021-12-31T23:00:00.000Z....

because the default FilenamePolicy uses a simple Instant format for Beam Windows that includes ":" which are illegal in MS Windows paths

Imported from Jira BEAM-13720. Original Jira may contain additional context.
Reported by: Gol.
@DwaipayanSom
Copy link

.take-issue

@bvolpato
Copy link
Contributor

This is a tricky scenario -- I don't think we can simply change the format as it could be a breaking change for existing non-Windows users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DwaipayanSom DwaipayanSom

Labels
bug good first issue io java P3 text
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bvolpato @damccorm @DwaipayanSom