From adc70adcead3c7c6b20668698ad1d7b272ec09cc Mon Sep 17 00:00:00 2001 From: Danny Mccormick Date: Mon, 23 Dec 2024 14:33:40 -0500 Subject: [PATCH] Doc + debug further --- CHANGES.md | 1 + .../beam/sdk/io/aws2/common/ClientBuilderFactory.java | 2 ++ sdks/python/apache_beam/io/kinesis.py | 6 +++--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 06b92953c662..b0dfc5af49ef 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -81,6 +81,7 @@ ## Breaking Changes * Upgraded ZetaSQL to 2024.11.1 ([#32902](https://github.com/apache/beam/pull/32902)). Java11+ is now needed if Beam's ZetaSQL component is used. +* AWS V1 I/Os have been removed (Java). As part of this, x-lang Python I/Os no longer support setting producer_properties ([#33430](https://github.com/apache/beam/issues/33430)). * X behavior was changed ([#X](https://github.com/apache/beam/issues/X)). ## Deprecations diff --git a/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/ClientBuilderFactory.java b/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/ClientBuilderFactory.java index 85aa99cea360..dc6825b1b815 100644 --- a/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/ClientBuilderFactory.java +++ b/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/common/ClientBuilderFactory.java @@ -184,6 +184,7 @@ public , ClientT> BuilderT if (skipCertificateVerification) { client.tlsKeyManagersProvider(NoneTlsKeyManagersProvider.getInstance()); + throw new Exception("Made it this far - probably means the tlsKeyManagersProvider is not right"); } // must use builder to make sure client is managed by the SDK @@ -212,6 +213,7 @@ public , ClientT> BuilderT if (skipCertificateVerification) { client.tlsKeyManagersProvider(NoneTlsKeyManagersProvider.getInstance()); + throw new Exception("Made it this far - probably means the tlsKeyManagersProvider is not right"); } // must use builder to make sure client is managed by the SDK diff --git a/sdks/python/apache_beam/io/kinesis.py b/sdks/python/apache_beam/io/kinesis.py index 94be0c44b709..ce0bb2623a38 100644 --- a/sdks/python/apache_beam/io/kinesis.py +++ b/sdks/python/apache_beam/io/kinesis.py @@ -147,9 +147,9 @@ def __init__( :param verify_certificate: Enable or disable certificate verification. Never set to False on production. True by default. :param partition_key: Specify default partition key. - :param producer_properties: Specify the configuration properties for Kinesis - Producer Library (KPL) as dictionary. - Example: {'CollectionMaxCount': '1000', 'ConnectTimeout': '10000'} + :param producer_properties: (Deprecated) This option no longer is available + since the AWS IOs upgraded to v2. Trying to set it will lead to an + error. For more info, see https://github.com/apache/beam/issues/33430. :param expansion_service: The address (host:port) of the ExpansionService. """ if producer_properties is not None: