From 7fd87e4f33a6e16cfc6e4b79c033935ebb6eb892 Mon Sep 17 00:00:00 2001 From: Robert Burke Date: Sun, 19 Feb 2023 05:55:34 -0800 Subject: [PATCH] [prism] move preparer --- .../beam/runners/prism/internal/preprocess.go | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/sdks/go/pkg/beam/runners/prism/internal/preprocess.go b/sdks/go/pkg/beam/runners/prism/internal/preprocess.go index cb1fcc30f070..8769a05d38f4 100644 --- a/sdks/go/pkg/beam/runners/prism/internal/preprocess.go +++ b/sdks/go/pkg/beam/runners/prism/internal/preprocess.go @@ -24,6 +24,17 @@ import ( "golang.org/x/exp/slog" ) +// transformPreparer is an interface for handling different urns in the preprocessor +// largely for exchanging transforms for others, to be added to the complete set of +// components in the pipeline. +type transformPreparer interface { + // PrepareUrns returns the Beam URNs that this handler deals with for preprocessing. + PrepareUrns() []string + // PrepareTransform takes a PTransform proto and returns a set of new Components, and a list of + // transformIDs leaves to remove and ignore from graph processing. + PrepareTransform(tid string, t *pipepb.PTransform, comps *pipepb.Components) (*pipepb.Components, []string) +} + // preprocessor retains configuration for preprocessing the // graph, such as special handling for lifted combiners or // other configuration. @@ -43,19 +54,8 @@ func newPreprocessor(preps []transformPreparer) *preprocessor { } } -// transformPreparer is an interface for handling different urns in the prepropcessor -// largely for exchanging transforms for others, to be added to the complete set of -// components in the pipeline. -type transformPreparer interface { - // PrepareUrns returns the Beam URNs that this handler deals with for preprocessing. - PrepareUrns() []string - // PrepareTransform takes a PTransform proto and returns a set of new Components, and a list of - // transformIDs leaves to remove and ignore from graph processing. - PrepareTransform(tid string, t *pipepb.PTransform, comps *pipepb.Components) (*pipepb.Components, []string) -} - // preProcessGraph takes the graph and preprocesses for consumption in bundles. -// The outputs the topological sort of the transform ids. +// The output is the topological sort of the transform ids. // // These are how transforms are related in graph form, but not the specific bundles themselves, which will come later. //