Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44373: [Packaging][Java] Fix brew link to Python 3.13 on macOS #44374

Merged
merged 4 commits into from
Oct 11, 2024
Merged

GH-44373: [Packaging][Java] Fix brew link to Python 3.13 on macOS #44374

merged 4 commits into from
Oct 11, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Oct 10, 2024 •
edited by kou
Loading

Rationale for this change

Java-jars are currently failing on macOS to install Python 3.13 because [email protected] (python is an alias of [email protected] now) isn't installed yet. Our link failure workaround is updating already installed python@* with --overwrite explicitly. [email protected] (python) isn't installed on GitHub Actions runner yet. So brew bundle installs python without --overwrite.

What changes are included in this PR?

Install python with --overwrite explicitly before brew bundle.

Are these changes tested?

Via CI

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Oct 10, 2024

@github-actions crossbow submit java-jars

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #44373 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 10, 2024
@github-actions GitHub Actions
Copy link

Revision: 42b2409

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b95b7ffd9

Task Status
java-jars GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Oct 10, 2024

@github-actions crossbow submit java-jars

@github-actions GitHub Actions
Copy link

Revision: be014ee

Submitted crossbow builds: ursacomputing/crossbow @ actions-70a9323a1e

Task Status
java-jars GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Oct 10, 2024

@github-actions crossbow submit java-jars

@github-actions GitHub Actions
Copy link

Revision: 68b424e

Submitted crossbow builds: ursacomputing/crossbow @ actions-55470c4dd9

Task Status
java-jars GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Oct 10, 2024

The only way I've found to fix the issue temporary is to pin python to 3.12 on cpp/Brewfile. @kou any other suggestion?
I think we could temporary pin to [email protected] for the release to fix java-jars but I am unsure of other possible things to try.

@kou
Copy link
Member

kou commented Oct 11, 2024

@github-actions crossbow submit java-jars

@github-actions GitHub Actions
Copy link

Revision: deab35b

Submitted crossbow builds: ursacomputing/crossbow @ actions-6ff8a791a6

Task Status
java-jars GitHub Actions

@kou kou marked this pull request as ready for review October 11, 2024 01:47
@kou
Copy link
Member

kou commented Oct 11, 2024

We can fix this by running brew install --overwrite python explicitly before brew bundle.
See the updated description for more details.

kou
kou approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit dcc1ee5 into apache:main Oct 11, 2024
9 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 11, 2024
@kou kou mentioned this pull request Oct 11, 2024
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 11, 2024
raulcd added a commit that referenced this pull request Oct 11, 2024
@raulcd
GH-44373: [Packaging][Java] Fix brew link to Python 3.13 on macOS (#4…
a39090d 
…4374)

### Rationale for this change

Java-jars are currently failing on macOS to install Python 3.13 because `python@ 3.13` (`python` is an alias of `python@ 3.13` now) isn't installed yet. Our link failure workaround is updating already installed `python@*` with `--overwrite` explicitly. `python@ 3.13` (`python`) isn't installed on GitHub Actions runner yet. So `brew bundle` installs `python` without `--overwrite`.

### What changes are included in this PR?

Install `python` with `--overwrite` explicitly before `brew bundle`.

### Are these changes tested?

Via CI

### Are there any user-facing changes?

No
* GitHub Issue: #44373

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dcc1ee5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

lriggs pushed a commit to lriggs/arrow that referenced this pull request Oct 18, 2024
@raulcd @lriggs
apacheGH-44373: [Packaging][Java] Fix brew link to Python 3.13 on mac…
e9dea8d 
…OS (apache#44374)

### Rationale for this change

Java-jars are currently failing on macOS to install Python 3.13 because `python@ 3.13` (`python` is an alias of `python@ 3.13` now) isn't installed yet. Our link failure workaround is updating already installed `python@*` with `--overwrite` explicitly. `python@ 3.13` (`python`) isn't installed on GitHub Actions runner yet. So `brew bundle` installs `python` without `--overwrite`.

### What changes are included in this PR?

Install `python` with `--overwrite` explicitly before `brew bundle`.

### Are these changes tested?

Via CI

### Are there any user-facing changes?

No
* GitHub Issue: apache#44373

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

Assignees
No one assigned
Labels
awaiting merge Awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulcd @kou