Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failure in json writer tests after upgrade from lexical-core 1.0.2 to lexical-core 1.0.3: range end index 20 out of range for slice of length 19 #6858

Closed
alamb opened this issue Dec 8, 2024 · 2 comments
Labels
bug development-process Related to development process of arrow-rs

Comments

@alamb
Copy link
Contributor

alamb commented Dec 8, 2024

Describe the bug

CI is failing on main, apparently related to the upgrade from lexical-core 1.0.2 to lexical-core 1.0.3

https://github.com/apache/arrow-rs/actions/runs/12216285082/job/34079214477

---- writer::tests::test_write_single_batch stdout ----
thread 'writer::tests::test_write_single_batch' panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lexical-write-integer-1.0.4/src/jeaiii.rs:304:29:
range end index 20 out of range for slice of length 19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- writer::tests::test_write_multi_batches stdout ----
thread 'writer::tests::test_write_multi_batches' panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lexical-write-integer-1.0.4/src/jeaiii.rs:304:29:
range end index 20 out of range for slice of length 19

---- writer::tests::write_arrays stdout ----
thread 'writer::tests::write_arrays' panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lexical-write-integer-1.0.4/src/jeaiii.rs:304:29:
range end index 20 out of range for slice of length 19

---- writer::tests::write_basic_rows stdout ----
thread 'writer::tests::write_basic_rows' panicked at /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lexical-write-integer-1.0.4/src/jeaiii.rs:304:29:
range end index 20 out of range for slice of length 19


failures:
    writer::tests::test_write_multi_batches
    writer::tests::test_write_single_batch
    writer::tests::write_arrays
    writer::tests::write_basic_rows

To Reproduce

# update to get lexical-core 1.0.3
cargo update
cargo test -p arrow-json --lib

Expected behavior
Tests should pass

Additional context

@alamb alamb added the bug label Dec 8, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 8, 2024

I am pretty sure this is a regression in upstream lexical-core

I filed an upstream ticket (with reproducer): Alexhuszagh/rust-lexical#191

@alamb alamb changed the title CI Failure in json writer tests after upgrade from lexical-core 1.0.2 to lexical-core 1.0.3 CI Failure in json writer tests after upgrade from lexical-core 1.0.2 to lexical-core 1.0.3: range end index 20 out of range for slice of length 19 Dec 8, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 9, 2024

Alexhuszagh/rust-lexical#191 has been fixed upstream ❤️

@alamb alamb closed this as completed Dec 9, 2024
@alamb alamb added the development-process Related to development process of arrow-rs label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug development-process Related to development process of arrow-rs
Projects
None yet
Development

No branches or pull requests

1 participant