Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RowSelection::intersection #3003

Closed
alamb opened this issue Nov 2, 2022 · 1 comment · Fixed by #3047
Closed

Add RowSelection::intersection #3003

alamb opened this issue Nov 2, 2022 · 1 comment · Fixed by #3047
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Nov 2, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
While @Ted-Jiang was working on apache/datafusion#3967 he needed code to intersect two row selections:

// combine two `RowSelection` return the intersection
// For example:
// self:     NNYYYYNNY
// other:    NYNNNNNNY
//
// returned: NNNNNNNNY
// set `need_combine` true will combine result: Select(2) + Select(1) + Skip(2) -> Select(3) + Skip(2)

The code and tests are in DataFusion

Describe the solution you'd like
I would like to code and tests brought to arrow-rs

see pub(crate) fn intersect_row_selection( specifically

Describe alternatives you've considered
Leave in DataFusion

Additional context

@alamb alamb added parquet Changes to the parquet crate enhancement Any new improvement worthy of a entry in the changelog labels Nov 2, 2022
@alamb alamb changed the title Add `RowSelection::intersection Add RowSelection::intersection Nov 2, 2022
@paddyhoran
Copy link
Contributor

+1 for moving this down into arrow-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants