Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRAINING ISSUE! Add extra CC: to the emails sent by Airflow #7782

Open
ashb opened this issue Mar 20, 2020 · 0 comments
Open

TRAINING ISSUE! Add extra CC: to the emails sent by Airflow #7782

ashb opened this issue Mar 20, 2020 · 0 comments
Labels
pinned Protect from Stalebot auto closing

Comments

@ashb
Copy link
Member

ashb commented Mar 20, 2020

Description

We need to have a way to add extra CC: to the emails sent by Airflow

Use case / motivation

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

This is a test issue that is used in Contributor's documentation to show an example issue for the first time contributors

Please do not merge the change even if you implement it!

The example workflow that uses this issue is described in
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

We need to have a way to add extra CC: to the emails sent by Airflow.

  1. You can see the information about how to configure email here email: [https://airflow.readthedocs.io/en/latest/concepts.html#email-configuration]
  2. Here is the class you should modify: airflow/utils/email.py
  3. Tests for email class are in: tests/utils/test_email.py
  4. Run the tests in Local Virtualenv: LOCAL_VIRTUALENV.rst
  5. Run the tests in Breeze: BREEZE.rst
  6. Make a DRAFT PR as described in https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contributions
  7. Run airflow webserver and scheduler and configure it to send emails and connect to a real SMTP server and test if the email is sent with the CC:'d account
@ashb ashb added the kind:feature Feature Requests label Mar 20, 2020
@apache apache locked and limited conversation to collaborators Mar 20, 2020
@eladkal eladkal added pinned Protect from Stalebot auto closing and removed kind:feature Feature Requests labels Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pinned Protect from Stalebot auto closing
Projects
None yet
Development

No branches or pull requests

2 participants