Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use proper file extension based on content-type #36

Merged
merged 2 commits into from
Aug 24, 2019

Conversation

antoinechalifour
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #36 into master will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36      +/-   ##
=======================================
+ Coverage   98.44%   99%   +0.56%     
=======================================
  Files          19    20       +1     
  Lines         257   404     +147     
  Branches       38    38              
=======================================
+ Hits          253   400     +147     
  Misses          1     1              
  Partials        3     3
Impacted Files Coverage Δ
...c/migrations/cache-fs/1-txt-to-proper-file-type.ts 100% <100%> (ø)
src/utils/path.ts 100% <100%> (ø) ⬆️
...infrastructure/repository/RequestRepositoryFile.ts 98.92% <100%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac020f...1b28204. Read the comment docs.

@antoinechalifour
Copy link
Owner Author

Releasing this feature as-is will be a breaking change as the old request will not be found (they will still be in .txt files).

One option is to execute mv body.txt body.mp3 at runtime to allow for migrations without breaking Memento

@antoinechalifour antoinechalifour merged commit f5fbade into master Aug 24, 2019
@antoinechalifour antoinechalifour deleted the file-extension branch August 24, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants