Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixing - Path Smoothing failures #308

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

Ulvetanna
Copy link
Collaborator

@Ulvetanna Ulvetanna commented Oct 31, 2024

PolarRoute Pull Request Template

Date:
Version Number:

Description of change

Fixing bug raised in #303

Fixed bug where dijkstra was called multiple times for the same graph

Fixed bug where early stopping criterion was not present in the codebase

Fixes # (issue)

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md.
This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

  • My changes have not altered any of the files listed in the testing strategy

  • My changes result in all required regression tests passing without the need to update test files.

list which files have been altered and include a pytest.txt file for each of
the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 1.1.x
  • My changes require one or more test files to be updated for all regression tests to pass.

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

  • My code follows pep8 style guidelines.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation of the codebase where required.
  • My changes generate no new warnings.
  • My PR has been made to the 1.1.x branch (DO NOT SUBMIT A PR TO MAIN)

@Ulvetanna Ulvetanna self-assigned this Oct 31, 2024
@Ulvetanna
Copy link
Collaborator Author

regression_tests.txt

Adding in regression tests

@Ulvetanna Ulvetanna requested review from hjabbot and gecoombs October 31, 2024 09:48
@Ulvetanna Ulvetanna added the Bug It might be considered a bug... label Oct 31, 2024
Copy link
Member

@gecoombs gecoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from my previous comment, could you also update the version number?

Copy link
Member

@gecoombs gecoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@gecoombs gecoombs linked an issue Nov 4, 2024 that may be closed by this pull request
@gecoombs gecoombs merged commit e6ba325 into 1.1.x Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It might be considered a bug...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoothing crashing due to indexing error
3 participants