Remove _linesearch from algorithms #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anriseth
force-pushed
the
anriseth/namechanges
branch
from
6ad6f07 to
582b612
Compare
Current coverage is 48.50% (diff: 31.00%)@@ master #16 diff @@
==========================================
Files 7 6 -1
Lines 602 602
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 292 292
Misses 310 310
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary to have _linesearch in all function names and files.
The
interpolation_linesearchseems to me to be just an implementation of algorithm 3.5-3.6 in Nocedal and Wright. It is meant to guarantee strong Wolfe conditions in the step length.I have therefore changed the name of this algorithm to
strongwolfeCloses #8