-
Notifications
You must be signed in to change notification settings - Fork 4
Fix: Binary string in email verification #1154
base: develop
Are you sure you want to change the base?
Conversation
@devkapilbansal Please check this! |
c68cb3a
to
b7859f9
Compare
b7859f9
to
266a634
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1154 +/- ##
===========================================
+ Coverage 86.93% 87.18% +0.24%
===========================================
Files 85 85
Lines 4057 4057
Branches 237 237
===========================================
+ Hits 3527 3537 +10
+ Misses 458 448 -10
Partials 72 72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @decon-harsh for your time.
The changes made in this PR were tested locally. Following are the results:
-
Code review - Done
-
All possible responses (positive and negative tests) were tested as below:
-
Additional Comments: As there was already a PR Bug: Fixed binary string in the url of email verification #1086 which was reviewed but messed by due to some changes, this PR can be labelled as Ready to Merge. Also, changes done in fix: Admin registration issue #1003 should be done first as there is a bug in registration too as witnessed in above screenshot.
-
Status of PR can be Changed to: Ready to Merge.
Thanks for your precious time @devkapilbansal . I guess i have nothing to change in this PR now? . Please keep this PR in mind while reviewing OSH works. |
Although this PR is same as the older one, but pinging @SanketDG @satya7289 @isabelcosta to look into this too |
@devkapilbansal thank you for the ping! |
When will it get merged? @devkapilbansal |
@decon-harsh consider asking for review on Zulip. After two approved reviews and testing, this PR can be merged. |
The url's uid was a b string. Decoded the uid to string. Removed some flake8 errors.
Fixes #1061
Initial PR #1086
Type of Change:
Code/Quality Assurance Only
Mocks
How Has This Been Tested?
Manually
Checklist:
Code/Quality Assurance Only