Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

methods should follow checks for password #750

Open
4 tasks
Monal5031 opened this issue Jun 27, 2018 · 16 comments · May be fixed by #1174
Open
4 tasks

methods should follow checks for password #750

Monal5031 opened this issue Jun 27, 2018 · 16 comments · May be fixed by #1174
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@Monal5031
Copy link
Contributor

Description

As a developer,
I need to make sure that my checks are being followed correctly,
so that I can find any inconsistencies in the code where the checks are not being executed.
Currently create_admin() and create_volunteer() create an admin and volunteer with password on which checks are not being executed this will be resolved until clean methods are defined in the models but then also we need to make sure we are using valid passwords.

Mocks

N/A

Acceptance Criteria

Update [Required]

  • Update methods to use valid passwords and follow checks
  • Update tests to follow these checks

Definition of Done

  • All of the required items are completed.
  • Approval by 2 mentor.

Estimation

40mins - 1 hr

@Monal5031 Monal5031 added Type: Question Further information is requested. Status: Needs Review PR needs an additional review or a maintainer's review. labels Jun 27, 2018
@Monal5031 Monal5031 self-assigned this Jun 28, 2018
@Monal5031 Monal5031 removed their assignment Aug 4, 2018
@Monal5031 Monal5031 added Type: Enhancement New feature or request. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. and removed Status: Needs Review PR needs an additional review or a maintainer's review. Type: Question Further information is requested. labels Aug 4, 2018
@khatryshikha
Copy link

@Monal5031, can you please explain this issue in more detail?

@Monal5031
Copy link
Contributor Author

The password has few constraints which are not being followed in the utility methods and methods in test suites. This issue is for changing those passwords which are not following the constraints. E.g. password used is password which clearly violates the constraints we have in place

@Monal5031
Copy link
Contributor Author

Yeah sure go ahead 👍 make sure to setup the project successfully first

@khatryshikha
Copy link

This seems to be interesting, may I take up this issue?

@khatryshikha
Copy link

Yes, sure!

@5anjana
Copy link

5anjana commented Feb 14, 2019

Hii @khatryshikha are you working on this issue?
I would like to take it up.

@5anjana
Copy link

5anjana commented Feb 23, 2019

I don't think @khatryshikha is working on this issue. Can you assign it to me? @Monal5031

@Kishan-Dhakan
Copy link
Contributor

Kishan-Dhakan commented Mar 15, 2020

@Monal5031 I would like to take this up next, shall I go for it? :)

@Monal5031
Copy link
Contributor Author

Please complete other issues first @Kishan-Dhakan :) It's better to have one issue assigned at a time.

@AnweshaSen
Copy link
Contributor

Is this issue available to be taken? I would like to work on this then !!

@Kishan-Dhakan
Copy link
Contributor

Please complete other issues first @Kishan-Dhakan :) It's better to have one issue assigned at a time.

I understand :)

@Aimaanhasan
Copy link

Hello, I'd like to work on this issue, Can I fix it?

@Monal5031 Monal5031 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 18, 2020
@abha224
Copy link

abha224 commented May 15, 2020

@Aimaanhasan are you still working on this issue?

@abha224
Copy link

abha224 commented May 30, 2020

@Aimaanhasan Pls let us know if you are still working on the issue so that we can open it up for others, in case you aren't.

@abha224 abha224 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jun 4, 2020
@aastha985
Copy link

@satya7289 I would like to work on this issue as a part of OSH. Can you assign it to me? thanks!

@NenadPantelic
Copy link

@Monal5031 @abha224 Hi, can you please elaborate on which constraints you want to be added here. At this point, there are active constraints:

  1. password must contain at least one digit, lowercase letter, an uppercase letter and one special char
  2. must be at least 6 chars long
    What do you suggest to add more? (I'm willing to do that)

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jan 8, 2021
NenadPantelic referenced this issue in NenadPantelic/vms Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
10 participants