Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of modules without TS definitions #313

Closed
13 tasks done
PuruVJ opened this issue Oct 23, 2021 · 23 comments
Closed
13 tasks done

List of modules without TS definitions #313

PuruVJ opened this issue Oct 23, 2021 · 23 comments

Comments

@PuruVJ
Copy link
Contributor

PuruVJ commented Oct 23, 2021

We're in the process of adding TypeScript definitions and tests to every Just utility. You're welcome to help us get there! Here's an example PR.

You can verify new TypeScript definitions by running yarn test-types (This also gets run as part of the yarn test script)

Here's a list of all the packages without TS definitions yet. Any contributors wanting to contribute TypeScript here could decide from this

Collections

  • just-diff-apply
  • just-compare
  • just-pluck-it
  • just-flush

Objects

  • just-entries
  • just-map-object
  • just-map-keys
  • just-reduce-object
  • just-is-primitive

Functions

  • just-compose
  • just-demethodize
  • just-flip
  • just-partial-it
@angus-c
Copy link
Owner

angus-c commented Oct 30, 2021

Updated to reflect new type additions. 22 left now.

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Oct 31, 2021

Got a question about Cartesian Product: Does it really have d.ts now? I updated my deps and VSCode still can't find it's typings

image

EDIT: Just found out it's v3.0.0 here, but on npm it's 1.0.2 only 🥲

@angus-c
Copy link
Owner

angus-c commented Oct 31, 2021

Should be published now

@maxsynnott
Copy link
Contributor

maxsynnott commented Nov 7, 2021

Created some PRs:

just-truncate #353
just-prune #354
just-template #355
just-is-empty #356
just-is-circular #357

Feedback appreciated

@angus-c
Copy link
Owner

angus-c commented Nov 7, 2021

Thanks Max. All landed except #356 (see comment)

@maxsynnott
Copy link
Contributor

Thanks Max. All landed except #356 (see comment)

Answered #356

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Nov 9, 2021

Now the hardest functions left to add the TS typings for 🥲

@Aryaman1706
Copy link
Contributor

Added typings for just-map-keys.
Kindly have a look:- #368

@maxsynnott
Copy link
Contributor

just-is-primitive #391

@maxsynnott
Copy link
Contributor

maxsynnott commented Dec 12, 2021

just-map-object should be checked off #386

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Dec 12, 2021

Done @maxsynnott

@Aryaman1706
Copy link
Contributor

Added types for just-flip
Kindly have a look #406

@Aryaman1706
Copy link
Contributor

Added types for just-flush
Kindly have a look #408

@eddie-atkinson
Copy link
Contributor

Added just-diff-apply #409

@seiyab
Copy link
Contributor

seiyab commented Jan 19, 2022

Added just-pluck-it #389

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jan 19, 2022

@angus-c lots of great stuff happening here 🔥

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jan 23, 2022

Only 6 packages left! 🔥

@justy-oak
Copy link
Contributor

Added just-compare #427

@angus-c
Copy link
Owner

angus-c commented Apr 9, 2022

One left! Thanks to @Masa-Shin

@breggle
Copy link
Contributor

breggle commented Apr 16, 2022

Added type definitions for function-curry #446
Well, it is just okay to call the curried function without any arguments. Not sure this is wanted? That PR do not prevent this, but it can with a litter modification.

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jun 1, 2022

Only one package left for typescript 🥳

@TClark1011
Copy link
Contributor

I've opened a PR with typings for the last package #469

@angus-c
Copy link
Owner

angus-c commented Jul 31, 2022

And we're done! Many thanks to everyone who helped with this. Great job!

@angus-c angus-c closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants