From 4fb27ce211a80e3210492e835051e974cf6ba553 Mon Sep 17 00:00:00 2001 From: ayazhafiz Date: Sun, 2 Feb 2020 13:31:44 -0800 Subject: [PATCH 1/2] docs: add section about mismatch in TS loading the language service Adds information about the issue seen in #594 to the README. cc @ikilinc. --- README.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/README.md b/README.md index 10f0600af9..db580f47eb 100644 --- a/README.md +++ b/README.md @@ -16,6 +16,19 @@ and external templates including: Download the extension from [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=Angular.ng-template). +## Versioning + +The langauge service extension uses the `@angular/language-service` package for its backend. This +package is loaded either from the version bundled with the extension, or from the current workspace +project the extension is running on. Due to the behavior of TypeScript below version 3.8, +incompatible versions of the language service may sometimes be loaded. If you are using a version of +TypeScript below 3.8, we suggest either + +- Not installing `@angular/language-service` in your project (recommended; will fallback on the + version bundled with the extension) +- Installing and keeping updates for the latest version of `@angular/language-service` + +For further information, please see #594. ## Installing a particular release build @@ -24,6 +37,7 @@ Download the `.vsix` file for the release that you want to install from the [rel *Do not open the .vsix file directly*. Instead, in Visual Studio code, go to the extensions tab. Click on the "..." menu in the upper right corner of the extensions tab, select "Install from vsix..." and then select the .vsix file for the release you just downloaded. The extension can also be installed with the following command: + ``` code --install-extension /path/to/ngls.vsix ``` From 76e0d350ca47046fa3ff5aed7c220f111756fa0f Mon Sep 17 00:00:00 2001 From: ayazhafiz Date: Mon, 3 Feb 2020 21:24:24 -0800 Subject: [PATCH 2/2] fixup! docs: add section about mismatch in TS loading the language service --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index db580f47eb..66a4088f84 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ Download the extension from [Visual Studio Marketplace](https://marketplace.visu ## Versioning -The langauge service extension uses the `@angular/language-service` package for its backend. This +The language service extension uses the `@angular/language-service` package for its backend. This package is loaded either from the version bundled with the extension, or from the current workspace project the extension is running on. Due to the behavior of TypeScript below version 3.8, incompatible versions of the language service may sometimes be loaded. If you are using a version of @@ -28,7 +28,7 @@ TypeScript below 3.8, we suggest either version bundled with the extension) - Installing and keeping updates for the latest version of `@angular/language-service` -For further information, please see #594. +For further information, please see [#594](https://github.com/angular/vscode-ng-language-service/issues/594). ## Installing a particular release build