Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($http): ignore xhr.responseType setter exception if value is "json" #6122

Closed
wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Feb 4, 2014

WebKit added support for the json responseType value on 09/03/2013 https://bugs.webkit.org/show_bug.cgi?id=73648. Versions of Safari prior to 7 are known to throw when setting the value "json" as the response type. Other older browsers implementing the responseType. Other browsers with infrequent update cycles may also be affected.

The json responseType value can be ignored if not supported, because JSON payloads are parsed on the client-side regardless.

Closes #6115

@IgorMinar
Copy link
Contributor

lgtm

@caitp caitp closed this in 431bad0 Feb 4, 2014
@caitp caitp reopened this Feb 5, 2014
WebKit added support for the json responseType value on 09/03/2013
https://bugs.webkit.org/show_bug.cgi?id=73648. Versions of Safari prior to 7 are known to throw when
setting the value "json" as the response type. Other older browsers implementing the responseType.
Other browsers with infrequent update cycles may also be affected.

The json responseType value can be ignored if not supported, because JSON payloads are parsed on the
client-side regardless.

Closes angular#6115
Closes angular#6122
@IgorMinar IgorMinar added this to the 1.2.12 milestone Feb 5, 2014
@caitp caitp closed this in 24699ee Feb 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$http responseType: 'json' triggers DOM Exception 12 in Mobile Webkit
2 participants