Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($browser): remove base href domain when url begins with '//' #5606

Closed
wants to merge 1 commit into from

Conversation

caitp
Copy link
Contributor

@caitp caitp commented Jan 3, 2014

This change prevents an incorrect appBase url from being calculated when the

href's domain begins with '//'.

Related to #5292, tangentially.

I don't know for sure if this is the correct behaviour, but it doesn't seem
totally unreasonable.

Before this change, if an app used <base href="//my.domain.com/app">, the entire href would be treated as a path, and $location would behave incorrectly, due to appending it to the initial domain.

So, that's a thing.

This change prevents an incorrect appBase url from being calculated when the
<base> href's domain begins with '//'.
@ghost ghost assigned IgorMinar Jan 3, 2014
@IgorMinar IgorMinar closed this in 760f2fb Jan 3, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This change prevents an incorrect appBase url from being calculated when the
<base> href's domain begins with '//'.

Closes angular#5606
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
This change prevents an incorrect appBase url from being calculated when the
<base> href's domain begins with '//'.

Closes angular#5606
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants