Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Controller not executed in nested directives with replace #3238

Closed
guinnberg opened this issue Jul 16, 2013 · 6 comments
Closed

Controller not executed in nested directives with replace #3238

guinnberg opened this issue Jul 16, 2013 · 6 comments

Comments

@guinnberg
Copy link

It's much easier having a quick look to the example in plunker than trying to explain.

Anyway the problem happens when you use nested directives, with the parent directive using replace. If the root element of the template is another directive it won't be processed, at least the directive controller.

Plunker: http://plnkr.co/edit/H1TIISvASAzAAP4oq0WK

@petebacondarwin
Copy link
Contributor

Is this issue fixed by #2738?

@guinnberg
Copy link
Author

@petebacondarwin how can I do to test it? I don't know how to checkout a pull request made by someone but me...

@cburgdorf
Copy link
Contributor

@ivogallego easy, just add the other guys repository as a remote:

git add remote lgalfaso https://github.com/lgalfaso/angular.js.git
then fetch his stuff

git fetch lgalfaso

Then checkout his branch:

`git checkout lgalfaso/master``

There are other ways to make it easier to check out PRs, but this one is pretty basic.

@guinnberg
Copy link
Author

Thanks @cburgdorf I'm a kind of newbie so I didn't know exactly how could I do it.

@petebacondarwin yes! your PR fix it! I updated the plunker just in case someone wanna check it!

@cburgdorf
Copy link
Contributor

your're welcome!

@IgorMinar
Copy link
Contributor

this was fixed by 45f9f62

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants