This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Controller not executed in nested directives with replace #3238
Comments
Is this issue fixed by #2738? |
@petebacondarwin how can I do to test it? I don't know how to checkout a pull request made by someone but me... |
@ivogallego easy, just add the other guys repository as a remote:
Then checkout his branch: `git checkout lgalfaso/master`` There are other ways to make it easier to check out PRs, but this one is pretty basic. |
Thanks @cburgdorf I'm a kind of newbie so I didn't know exactly how could I do it. @petebacondarwin yes! your PR fix it! I updated the plunker just in case someone wanna check it! |
your're welcome! |
this was fixed by 45f9f62 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It's much easier having a quick look to the example in plunker than trying to explain.
Anyway the problem happens when you use nested directives, with the parent directive using replace. If the root element of the template is another directive it won't be processed, at least the directive controller.
Plunker: http://plnkr.co/edit/H1TIISvASAzAAP4oq0WK
The text was updated successfully, but these errors were encountered: